Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installing pino-applicationinsights has broken storybook builds #299

Closed
1 task
rocketnova opened this issue Jul 9, 2021 · 1 comment · Fixed by #358
Closed
1 task

Installing pino-applicationinsights has broken storybook builds #299

rocketnova opened this issue Jul 9, 2021 · 1 comment · Fixed by #358
Assignees
@rocketnova
Labels
Engineering Technology and Development Track Size: L
Milestone
Build MVP: Prep i...

Comments

@rocketnova
Copy link
Contributor

rocketnova commented Jul 9, 2021 •
edited by kalvinwang
Loading

Description

Sadly, #288 broke storybook builds. See https://github.com/cagov/ui-claim-tracker/runs/3023514358?check_suite_focus=true. yarn storybook-build is also broken locally for main.

If this takes more than a day or two, consider whether it does make sense to use pino-applicationinsights

Acceptance Criteria

  • Storybook builds work again
@rocketnova rocketnova added the Engineering Technology and Development Track label Jul 9, 2021
@rocketnova rocketnova self-assigned this Jul 9, 2021
@lomky
Copy link
Contributor

lomky commented Jul 9, 2021

Poked at this for a minute - the sb build fails whether isAzureEnv is true or false, and succeeds if you comment out the await createWriteStream, so its something in the actual build step there

@kalvinwang kalvinwang mentioned this issue Jul 12, 2021
Merged
3 tasks
This was referenced Jul 13, 2021
Merged
Merged
@rocketnova rocketnova removed their assignment Jul 15, 2021
This was referenced Jul 16, 2021
Merged
Merged
Merged
@rocketnova rocketnova mentioned this issue Jul 21, 2021
Merged
@rocketnova rocketnova self-assigned this Jul 21, 2021
This was referenced Jul 27, 2021
Merged
Merged
Merged
@rocketnova rocketnova mentioned this issue Aug 4, 2021
Closed
3 tasks
@rocketnova rocketnova mentioned this issue Aug 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rocketnova rocketnova

Labels
Engineering Technology and Development Track Size: L
Projects
None yet
Milestone
Build MVP: Prep infra and tooling for...
Development

Successfully merging a pull request may close this issue.

Fix pino-applicationinsights in storybook cagov/ui-claim-tracker
4 participants
@rocketnova @kalvinwang @lomky @dianagriffin-zz