Implement next steps logic #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rocketnova
commented
Jul 16, 2021
lomky
reviewed
Jul 19, 2021
lomky
reviewed
Jul 19, 2021
lomky
reviewed
Jul 19, 2021
Comment on lines
+115
to
+120
| return { | ||
| heading: buildClaimStatusHeading(scenarioType), | ||
| summary: buildClaimStatusSummary(scenarioObject, scenarioString), | ||
| yourNextSteps: buildNextSteps(scenarioObject, scenarioString, 'your-next-steps'), | ||
| eddNextSteps: buildNextSteps(scenarioObject, scenarioString, 'edd-next-steps'), | ||
| } |
There was a problem hiding this comment.
github mangled this file's diff so much that I had an excuse to use vimdiff for the first time in ages!
Really like this return refactor. 👨🏼🍳👌🏼
lomky
reviewed
Jul 19, 2021
kalvinwang
approved these changes
Jul 19, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Resolves #316
Changes
<em>elements in<Trans>components<NextSteps>component to expect to create text that might contain linkses6Context
This PR adds in support for the latest next steps content: "Your Next Steps" and "EDD Next Steps".
A major change to note is that I've updated the Typescript target from
es5toes2015in order to support iterating over anIterableIteratortype. Let me know if this is going to be an issue for us.Note: This PR does not include the conditional next step about certification (coming in a future PR).
Testing
yarn testPLUS
While #299 is not resolved, comment out these lines, then run
yarn storybook, and check that each scenario displays the next steps from the latest content (including correct links):ui-claim-tracker/pages/index.tsx
Lines 95 to 98 in 32990f8