Connect to API Gateway #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… kevmo/api-gateway # Conflicts: # components/ClaimCard.tsx
… available and proper env variables are set.
kevmo
commented
May 19, 2021
kalvinwang
reviewed
May 20, 2021
3 tasks
rocketnova
reviewed
Jun 2, 2021
kalvinwang
approved these changes
Jun 7, 2021
Co-authored-by: Kalvin Wang <kalvinwang@users.noreply.github.com>
kalvinwang
reviewed
Jun 7, 2021
|
|
||
| import { Header } from '../components/Header' | ||
| import { Main } from '../components/Main' | ||
| import { Footer } from '../components/Footer' | ||
|
|
||
| export default function Home(): ReactElement { | ||
| export interface Claim { | ||
| ClaimType: string | 'not working' |
There was a problem hiding this comment.
should this be ?? '' for now and error handled later?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR represents our work connecting with the API gateway in a secure way. Some code/comments are there to mark places that need work once development from the API team is finished (e.g. the unique number header we are expecting from UIO, an API response with end user information in it rather than a placeholder).
Environmental variables (in a root-level
.envfile) are used to make the code more configurable in the event of URL/header/parameter changes in the future.===
Resolves #XXX