Split scenario "base state (no pending weeks)" into two sub scenarios #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rocketnova
commented
Jun 29, 2021
rocketnova
added
Engineering
lomky
reviewed
Jun 29, 2021
rocketnova
commented
Jul 2, 2021
| else { | ||
| // throw new Error('Unexpected scenario') |
There was a problem hiding this comment.
Note: The new logic I went over with Nicole and Diana shouldn't leave an opportunity for an unknown scenario. We will also have an additional layer of API gateway response validation (#150) that will make unexpected response values not possible.
lomky
reviewed
Jul 6, 2021
This was referenced Jul 8, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Related to #242
Changes
I18nStringinstead of juststringfor extra clarityContext
While going through the content matrix, I discovered that I didn't break out the scenarios at the correct level of granularity in order to display the content we want to show. After getting confirmation about this from @nicoleslaw and Diana, this PR corrects that.
Testing
yarn test