Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WANDA-5] feat(wanda): add dns config into pod's template #243

Merged
merged 1 commit into from
Nov 24, 2020

Conversation

hezhizhen
Copy link

@hezhizhen hezhizhen commented Nov 24, 2020

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR is related to (optional, link to 3rd issue(s)):

Fixes #

Reference to https://jira.bytedance.com/browse/WANDA-5

Special notes for your reviewer:

/cc @your-reviewer

Does this PR introduce a user-facing change?:


@caicloud-bot caicloud-bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Nov 24, 2020
@hezhizhen
Copy link
Author

cherry-pick #181

@caicloud-bot caicloud-bot added the caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. label Nov 24, 2020
@hezhizhen
Copy link
Author

/release-note-none
/assign @qianlei90

@caicloud-bot caicloud-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 24, 2020
@qianlei90 qianlei90 changed the title feat(wanda): add dns config into pod's template [WANDA-5] feat(wanda): add dns config into pod's template Nov 24, 2020
@qianlei90
Copy link
Contributor

/lgtm

@caicloud-bot caicloud-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2020
@caicloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qianlei90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caicloud-bot caicloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2020
@caicloud-bot caicloud-bot merged commit c1e3767 into caicloud:cps-2.10/wanda Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants