Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change vue dep to be lower bound #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

robinp
Copy link

@robinp robinp commented Apr 4, 2021

Previously it was fixed version, pulling in duplicate Vue into the user project potentially.

Noticed by running the webpack-bundle-analyzer plugin (see https://dev.to/m9hmood/reduce-vue-js-application-size-kfl), then did npm ls vue, which printed

$ npm ls vue                                                                                                                                               
my-ui
├── vue@2.6.9
├─┬ vue-backtotop@1.6.1                                                                                                                                                                                              
  └── vue@2.3.3                                                                                                                                                                                                    ```
Thanks for the component btw!

Previously it was fixed version, pulling in duplicate Vue into the user project potentially.
@robinp
Copy link
Author

robinp commented Jan 11, 2022

Gentle ping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant