Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task-runner: Rework regex to be more flexible #52

Closed
nalla opened this issue Dec 1, 2016 · 0 comments
Closed

task-runner: Rework regex to be more flexible #52

nalla opened this issue Dec 1, 2016 · 0 comments

Comments

@nalla
Copy link
Contributor

nalla commented Dec 1, 2016

Some projects may enforce special coding style guidelines on their projects. To be more flexible in this area the regex that is used to identify task names should be more flexible.

This issue is the result of the quick discussion in the gitter chat:

@gep13 https://github.com/cake-build/cake-vs/blob/develop/src/TaskRunner/TaskParser.cs#L25 Are you open to a PR that will improve that regex to https://regex101.com/r/vrnDgB/1 ?
@gep13 https://regex101.com/r/vrnDgB/3 is even better ;)
@nalla certainly not against a PR. /cc @agc93
@agc93 agc93 closed this as completed in f78d0c3 Dec 2, 2016
agc93 added a commit that referenced this issue Dec 2, 2016
@agc93
Merge pull request #51 from nalla/support-spaces-in-tasknames
8cb70ab 
(GH-52) Rework regex to allow whitespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nalla