Preprocessor keywords #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soroshsabz
reviewed
Jan 23, 2020
build.cake
Outdated
| @@ -9,7 +9,7 @@ var configuration = Argument("configuration", "Release"); | |||
| // TOOLS / ADDINS | |||
| ////////////////////////////////////////////////////////////////////// | |||
|
|
|||
| #addin "nuget:https://www.nuget.org/api/v2?package=MagicChunks&version=1.2.0.58" | |||
| #addin "nuget:?package=MagicChunks" | |||
There was a problem hiding this comment.
Please add version, because we got warning
The 'tool' directive is attempting to install the 'MagicChunks' package
without specifying a package version number.
More information on this can be found at https://cakebuild.net/docs/tutorials/pinning-cake-version
It's not recommended, but you can explicitly override this warning
by configuring the Skip Package Version Check setting to true
(i.e. command line parameter "--settings_skippackageversioncheck=true",
environment variable "CAKE_SETTINGS_SKIPPACKAGEVERSIONCHECK=true",
read more about configuration at https://cakebuild.net/docs/fundamentals/configuration)
gep13
force-pushed
the
preprocessor-keywords
branch
from
719af9e to
8425f85
Compare
gep13
force-pushed
the
preprocessor-keywords
branch
from
8425f85 to
e04088d
Compare
|
@sierzput thank you very much for taking the time to submit this PR, and apologies that it has taken this long to address it. This should go out in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing preprocessor keywords and update packages to eliminate build errors