Merge pull request #955 from patriksvensson/feature/GH671

GH671: Fixed argument parsing bug.
cake-build · Jun 6, 2016 · 004912d · 004912d
2 parents c87814b + 188349f
commit 004912d
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 2 deletions.
diff --git a/src/Cake.Tests/Unit/Arguments/ArgumentTokenizerTests.cs b/src/Cake.Tests/Unit/Arguments/ArgumentTokenizerTests.cs
@@ -81,6 +81,22 @@ public void Should_Parse_Multiple_Mixed_Arguments()
                 Assert.Equal("-verbosity", result[2]);
                 Assert.Equal("\"diagnostic\"", result[3]);
             }
+
+            [Fact]
+            public void Should_Parse_Part_That_Contains_Quotes_With_Space_In_It()
+            {
+                // Given
+                const string input = @"cake.exe build.cake -target=""te st""";
+
+                // When
+                var result = ArgumentTokenizer.Tokenize(input).ToArray();
+
+                // Then
+                Assert.Equal(3, result.Length);
+                Assert.Equal("cake.exe", result[0]);
+                Assert.Equal("build.cake", result[1]);
+                Assert.Equal("-target=\"te st\"", result[2]);
+            }
         }
     }
 }
diff --git a/src/Cake/Arguments/ArgumentTokenizer.cs b/src/Cake/Arguments/ArgumentTokenizer.cs
@@ -55,11 +55,18 @@ private static string Read(StringReader reader)
             accumulator.Append((char)reader.Read());
             while (reader.Peek() != -1)
             {
-                if ((char)reader.Peek() == ' ')
+                if ((char)reader.Peek() == '\"')
+                {
+                    accumulator.Append(ReadQuote(reader));
+                }
+                else if ((char)reader.Peek() == ' ')
                 {
                     break;
                 }
-                accumulator.Append((char)reader.Read());
+                else
+                {
+                    accumulator.Append((char)reader.Read());
+                }
             }
             return accumulator.ToString();
         }