Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added raw version string property in ReleaseNotes class #1086

Closed
ThatRendle opened this issue Jul 20, 2016 · 5 comments
Closed

Added raw version string property in ReleaseNotes class #1086

ThatRendle opened this issue Jul 20, 2016 · 5 comments
Milestone

Comments

@ThatRendle
Copy link

This is kind of a follow-on from #885

@Redth's SemVer package is great for parsing strings.
Built-in ReleaseNotesParser is great for extracting strings from a MarkDown file, but ReleaseNotes contains a typed Version property, with anything like -preview3-rc8-0002938 stripped off.
If the Parser included the raw string that the Version was parsed from, we could send it off to SemVer for more complex parsing.

@gep13
Copy link
Member

gep13 commented Jul 20, 2016

@markrendle I think that this would be a sensible addition. Would you be in a position to submit a PR for this? Would be more than happy to accept it 😄

@ThatRendle
Copy link
Author

I'll see what I can do...

@ThatRendle
Copy link
Author

Done: #1087

@gep13
Copy link
Member

gep13 commented Jul 20, 2016

@markrendle said,,,
Done: #1087

Cool, will take a look tonight.

@gep13 gep13 changed the title Feature Request: Raw version string in ReleaseNotes Added raw version string property in ReleaseNotes class Jul 20, 2016
@gep13 gep13 closed this as completed in 3f948db Jul 20, 2016
@gep13 gep13 added this to the v0.15.0 milestone Jul 20, 2016
@gep13
Copy link
Member

gep13 commented Jul 20, 2016

@markrendle thanks again for your contribution to Cake 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants