Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UploadArtifact support via the AppVeyor provider is incomplete #1096

Closed
Philo opened this issue Jul 22, 2016 · 1 comment
Closed

UploadArtifact support via the AppVeyor provider is incomplete #1096

Philo opened this issue Jul 22, 2016 · 1 comment
Labels
Improvement
Milestone
v0.15.0

Comments

@Philo
Copy link
Contributor

Philo commented Jul 22, 2016

Raising the issue to attach to my incoming pull request to add these options :)

What You Are Seeing?

The .UploadArtifact(FilePath path) method does not support the full options available for AppVeyor.

What is Expected?

appveyor <path> [-FileName <string>] [-DeploymentName <string>] [-Type <type> {Auto, WebDeployPackage, NuGetPackage}]

BuildSystem.AppVeyor.UploadArtifact("./artifacts/webdeploy.zip", AppVeyorUploadArtifactType.WebDeployPackage);

BuildSystem.AppVeyor.UploadArtifact("./artifacts/package.zip"); // Uploads as "Auto"

BuildSystem.AppVeyor.UploadArtifact("./artifacts/webdeploy.zip", AppVeyorUploadArtifactType.WebDeployPackage, "MyApp.Web"); // assigns deployment name as required when using the deployment agent

What version of Cake are you using?

0.14.0

Are you running on a 32 or 64 bit system?

64 bit

What environment are you running on? Windows? Linux? Mac?

AppVeyor (Windows)

Are you running on a CI Server? If so, which one?

AppVeyor
Philo added a commit to Philo/cake that referenced this issue Jul 22, 2016
@Philo
Updates AppVeyor UploadArtifact method
b98f713 
Adds support for the additional options available on the underlying
"appveyor PushArtifact" command line:

* -Type "Auto|WebDeployPackage|NuGetPackage"
* -DeploymentName "<string>"

Resolves cake-build#1096
@Philo Philo mentioned this issue Jul 22, 2016
Closed
Philo added a commit to Philo/cake that referenced this issue Jul 22, 2016
@Philo
re cake-build#1096 - Updates UploadArtifacts to use a settings class
c70bc7d 
Adds:

* UploadArtifacts(path);
* UploadArtifacts(path, settings);
* UploadArtifacts(path, settings => settings.UploadAs(AppVeyorUploadArtifactType.WebDeployPackage));
@gep13 gep13 modified the milestone: v0.15.0 Jul 24, 2016
Philo added a commit to Philo/cake that referenced this issue Jul 25, 2016
@Philo
Updates AppVeyor UploadArtifact method
f5dc0f2 
Adds support for the additional options available on the underlying
"appveyor PushArtifact" command line:

Adds:

* UploadArtifacts(path);
* UploadArtifacts(path, settings);
* UploadArtifacts(path, settings => settings.SetArtifactType(AppVeyorUploadArtifactType.WebDeployPackage));

Resolves cake-build#1096
@gep13 gep13 closed this as completed in 4d8f65d Jul 25, 2016
gep13 added a commit that referenced this issue Jul 25, 2016
@gep13
(GH-1096) Corrected CodeAnalysis Warnings
d6d58fc
@gep13
Copy link
Member

gep13 commented Jul 25, 2016

@Philo thanks again! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
v0.15.0
Development

No branches or pull requests
2 participants
@Philo @gep13