Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensured that WiX candle definitions are enclosed in quotes #1131

Closed
galpin opened this issue Jul 28, 2016 · 0 comments
Closed

Ensured that WiX candle definitions are enclosed in quotes #1131

galpin opened this issue Jul 28, 2016 · 0 comments
Labels
Milestone

Comments

@galpin
Copy link
Contributor

galpin commented Jul 28, 2016

What You Are Seeing?

WiX candle fails when a define is added that includes a space in the value because the command line runner does not enclose the value in quotations.

What is Expected?

The command line arguments should enclose define values in quotes.

What version of Cake are you using?

0.15.0

Are you running on a 32 or 64 bit system?

64-bit

What environment are you running on? Windows? Linux? Mac?

Windows

Are you running on a CI Server? If so, which one?

No

How Did You Get This To Happen? (Steps to Reproduce)

WiXCandle("app.wxs", new CandleSettings
{
    Defines = new Dictionary<string, string>
    {
        { "ProductName", "Amazing Product Name" }
    }
});

Output Log

Executing: "tools/WiX.Toolset/tools/wix/candle.exe" -arch x86 -dProductName=Amazing Product Name "app.wxs"
candle.exe : error CNDL0103 : The system cannot find the file 'Product' with type 'Source'.
@gep13 gep13 modified the milestone: v0.15.2 Jul 28, 2016
@gep13 gep13 added the Bug label Jul 28, 2016
@gep13 gep13 changed the title WiX candle definitions should be enclosed with quotes Ensured that WiX candle definitions are enclosed in quotes Jul 28, 2016
@gep13 gep13 closed this as completed Jul 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants