Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ability to Redirect Standard Error on IProcess #1172

Closed
CaptainCow95 opened this issue Aug 18, 2016 · 3 comments
Closed

Add Ability to Redirect Standard Error on IProcess #1172

CaptainCow95 opened this issue Aug 18, 2016 · 3 comments
Labels
Milestone

Comments

@CaptainCow95
Copy link
Contributor

I was looking into redirecting standard error, as that is what one of the git commands I'm running writes to so that I can suppress it, and noticed that while it isn't currently implemented, it would be a pretty easy thing for me to add and send a pull-request for. The problem is that adding it would likely involve adding a function to the IProcess interface, effectively breaking any code that uses that interface when they would use the version that contains that addition. Is there any sort of process laid out to add things like this without breaking compatibility?

@devlead
Copy link
Member

devlead commented Aug 18, 2016

I think it would make sense to add GetStandardError() to IProcess and add an RedirectStandardError to ProcessSettings.

@CaptainCow95
Copy link
Contributor Author

I'll go ahead and write up a pull-request then. We can talk about what would need to happen to safely change the interface once we see all the changes that would have to be made.

@devlead
Copy link
Member

devlead commented Oct 20, 2016

Fixed by #1175

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants