Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH1172: Adding GetStandardError to IProcess and RedirectStandardError to ProcessSettings #1175

Merged
merged 2 commits into from
Oct 20, 2016
Merged

Conversation

CaptainCow95
Copy link
Contributor

Adds the ability to redirect the standard error in the same way that you can currently redirect standard output. Related to #1172

@dnfclas
Copy link

dnfclas commented Aug 19, 2016

Hi @CaptainCow95, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@dnfclas
Copy link

dnfclas commented Aug 19, 2016

@CaptainCow95, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

@devlead devlead changed the title Adding GetStandardError to IProcess and RedirectStandardError to ProcessSettings GH1172: Adding GetStandardError to IProcess and RedirectStandardError to ProcessSettings Aug 28, 2016
@devlead
Copy link
Member

devlead commented Oct 18, 2016

@CaptainCow95 Hi are you in a position to rebase this against latest develop?

@CaptainCow95
Copy link
Contributor Author

I'll try to get to it tonight.

@CaptainCow95
Copy link
Contributor Author

Should be all synced up now.

Copy link
Member

@devlead devlead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@devlead devlead merged commit edd401b into cake-build:develop Oct 20, 2016
@devlead
Copy link
Member

devlead commented Oct 20, 2016

@CaptainCow95 this is now merged and will be avail in next release, thanks for contributing 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants