System time separator is used when Octo DeployAt argument is converted to string

[bjorkstromm]

What You Are Seeing?

System time separator '.' is used instead of ':' what is expected in the --deployat argument for Octo CreateRelease and Octo DeployRelease

What is Expected?

That the time separator ':' should always be used regardless of system settings.

What version of Cake are you using?

0.17.0-*

Are you running on a 32 or 64 bit system?

64-bit

What environment are you running on? Windows? Linux? Mac?

Windows

Are you running on a CI Server? If so, which one?

Nope

How Did You Get This To Happen? (Steps to Reproduce)

Switch to Finnish regional settings (In Windows 10, default Finnish regional settings will set time separator as '.') or switch Time Separator to '.' and run \build.ps1 and watch unit tests fail.

Output Log

Cake.Common.Tests.Unit.Tools.OctopusDeploy.OctoDeployReleaseTests+DeploymentArgumentBuilder.Should_Add_DeployAt_To_Arguments_If_Specified [FAIL]
      Assert.Equal() Failure
                                       � (pos 151)
      Expected: ···loyat="2010-06-15 00:01"
      Actual:   ···loyat="2010-06-15 00.01"
                                       � (pos 151)
      Stack Trace:
        src\Cake.Common.Tests\Unit\Tools\OctopusDeploy\OctoDeployReleaseTests.cs(408,0): at Cake.Common.Tests.Unit.Tools.OctopusDeploy.OctoDeployReleaseTests.DeploymentArgumentBuilder.Should_Add_DeployAt_To_Arguments_If_Specified()

[bjorkstromm]

Fix by switching:

Builder.AppendSwitchQuoted("--deployat", "=", _settings.DeployAt.Value.ToString("yyyy-MM-dd HH:mm"));

to

Builder.AppendSwitchQuoted("--deployat", "=", _settings.DeployAt.Value.ToString("yyyy-MM-dd HH:mm", CultureInfo.InvariantCulture));

[gep13]

@mholo65 this sounds like a very sensible change to me. Are you in a position to create a PR for this? If not, I can make the change.

[bjorkstromm]

I'm doing it now!