Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code sample to build system properties #1811

Closed
devlead opened this issue Sep 17, 2017 · 4 comments
Closed

Add code sample to build system properties #1811

devlead opened this issue Sep 17, 2017 · 4 comments
Assignees
Milestone

Comments

@devlead
Copy link
Member

devlead commented Sep 17, 2017

As the build system properties go pretty deep it would be really helpful if the properties had code samples i.e.
Jenkins BuildNumber

Not super obvious that it's accessed like this
BuildSystem.Jenkins.Environment.Build.BuildNumber

@Roemer
Copy link
Contributor

Roemer commented Sep 26, 2017

This comes back to my question when I did the PR for additional Jenkins variables:
Do we really need to have them that deep?
Stuff like the Workspace could be in Build or in Node, Changes are also related to Build or Repository, Job is also related to Build and and and. All in all if you need something it's always a search until you found what you need.
I suggest having only one Environment class which directly contains all environment variables.

@devlead
Copy link
Member Author

devlead commented Sep 26, 2017

Well they're what they are in a way, we don't want unnecessary break too many scripts out there if it's not for real benefit.

@phillipsj
Copy link
Contributor

This one is hanging out here, I will take it.

@devlead
Copy link
Member Author

devlead commented Dec 15, 2017

@phillipsj Excellent I've assigned issue to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants