Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH1811: Adding examples for build properties. #1954

Merged
merged 1 commit into from
Dec 18, 2017
Merged

GH1811: Adding examples for build properties. #1954

merged 1 commit into from
Dec 18, 2017

Conversation

phillipsj
Copy link
Contributor

Just wanted to get this out there to make sure that the documentation is exactly what is expected before I do the rest. Fixes #1811 @devlead

@devlead
Copy link
Member

devlead commented Dec 16, 2017

@phillipsj yip, you're on the right track 👍

@phillipsj phillipsj changed the title [WIP] Adding AppVeyor environment. Adding examples for build properties. Dec 17, 2017
@phillipsj
Copy link
Contributor Author

This should all be complete.

Copy link
Member

@devlead devlead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I'll merge once CI finishes.

@devlead devlead changed the title Adding examples for build properties. GH1811: Adding examples for build properties. Dec 18, 2017
@devlead devlead merged commit 3bd6073 into cake-build:develop Dec 18, 2017
@devlead
Copy link
Member

devlead commented Dec 18, 2017

@phillipsj your changes have been merged, thanks for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants