Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for PublishReadyToRunShowWarnings property in DotNetCorePublish #2839

Closed
augustoproiete opened this issue Aug 9, 2020 · 1 comment · Fixed by #2840
Closed

Add support for PublishReadyToRunShowWarnings property in DotNetCorePublish #2839

augustoproiete opened this issue Aug 9, 2020 · 1 comment · Fixed by #2840
Assignees
@augustoproiete
Labels
Improvement
Milestone
v1.0.0

Comments

@augustoproiete
Copy link
Member

What You Are Seeing?

When publishing .NET Core 3+ apps that are compiled with ReadyToRun enabled can emit warnings, indicating potential missing dependencies that could potentially cause runtime failures. To show the warnings, we can set the PublishReadyToRunShowWarnings property to true when calling dotnet publish.

DotNetCorePublishSettings currently supports the property PublishReadyToRun, but doesn't yet support the property PublishReadyToRunShowWarnings.

C:/augustoproiete/my-app/build.cake(49,9): error CS0117: 'DotNetCorePublishSettings' does not contain a definition for 'PublishReadyToRunShowWarnings'

What is Expected?

DotNetCorePublish("./src/MyApp/MyApp.csproj", new DotNetCorePublishSettings
{
    // ...
    PublishReadyToRun = true,
    PublishReadyToRunShowWarnings = true, // <<<
});

What version of Cake are you using?

0.38.4
augustoproiete added a commit to augustoproiete-forks/cake-build--cake that referenced this issue Aug 9, 2020
@augustoproiete
(cake-buildGH-2839) Add support for PublishReadyToRunShowWarnings pro…
433eba5 
…perty in DotNetCorePublish

```csharp
DotNetCorePublish("./src/MyApp/MyApp.csproj", new DotNetCorePublishSettings
{
    // ...
    PublishReadyToRun = true,
    PublishReadyToRunShowWarnings = true, // <<<
});
```
@augustoproiete augustoproiete mentioned this issue Aug 9, 2020
Merged
augustoproiete added a commit to augustoproiete-forks/cake-build--cake that referenced this issue Sep 7, 2020
@augustoproiete
(cake-buildGH-2839) Add support for PublishReadyToRunShowWarnings pro…
ab8a551 
…perty in DotNetCorePublish

```csharp
DotNetCorePublish("./src/MyApp/MyApp.csproj", new DotNetCorePublishSettings
{
    // ...
    PublishReadyToRun = true,
    PublishReadyToRunShowWarnings = true, // <<<
});
```
@devlead devlead added this to the v1.0.0 milestone Sep 7, 2020
@devlead devlead mentioned this issue Nov 5, 2020
Closed
@cake-build-bot
Copy link

🎉 This issue has been resolved in version v1.0.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

@augustoproiete augustoproiete self-assigned this Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@augustoproiete augustoproiete

Labels
Improvement
Projects
None yet
Milestone
v1.0.0
3 participants
@augustoproiete @devlead @cake-build-bot