Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNUPackSettings OutputDirectory should be a DirectoryPath #624

Closed
reicheltp opened this issue Jan 8, 2016 · 5 comments
Closed

DNUPackSettings OutputDirectory should be a DirectoryPath #624

reicheltp opened this issue Jan 8, 2016 · 5 comments
Labels
Milestone

Comments

@reicheltp
Copy link
Contributor

The OutputDirectory property in DNUPackSettings should be a DirectoryPath not a FilePath. Thus I get an error if I wanna do the following code:

var output = Directory("./output");

Task("pack")
    .Does(() => DNUPack(src, new DNUPackSettings 
    { 
        OutputDirectory = output,
        Configurations = new [] {configuration}
    }));

Responding file:
https://github.com/cake-build/cake/blob/develop/src/Cake.Common/Tools/DNU/Pack/DNUPackSettings.cs

@devlead
Copy link
Member

devlead commented Jan 8, 2016

@reicheltp totally correct, thanks for reporting 👍

@devlead devlead added this to the v0.8.0 milestone Jan 8, 2016
@devlead devlead added the Bug label Jan 8, 2016
@reicheltp
Copy link
Contributor Author

@devlead
Copy link
Member

devlead commented Jan 8, 2016

@reicheltp something you would like to submit a PR for? Otherwise I'll take a look at fixing this.

@reicheltp
Copy link
Contributor Author

I can do it later today. :)

@devlead
Copy link
Member

devlead commented Jan 8, 2016

@reicheltp superb 👍 , just create a PR referencing that it fixes this issue in commit & pr message using the fixes syntax.

reicheltp added a commit to reicheltp/cake that referenced this issue Jan 8, 2016
devlead added a commit that referenced this issue Jan 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants