Don't show delegating tasks in summary

[gep13]

i.e. Tasks that are only used to tie together other tasks. If there is no action associated with the Task, don't show it in the summary.

[patriksvensson]

👍

[RichiCoder1]

Or show it in a non-tasky way to may it clear it's a summary or branch task.

[ErikSchierboom]

How would you like the delegating task to be displayed? In grey, just like skipped tasks? And what should be the displayed text?

[ErikSchierboom]

In a previous PR, I add a Skipped property to the CakeReportEntry class. However, I now think that should really have been an enumeration. That way, we can have an enumeration that specifies the executed task's status: Executed, Skipped or Delegated. Should I replace the boolean property with an enumeration, or create an additional boolean property?

[patriksvensson]

@ErikSchierboom I agree with your thinking. An enum would be much cleaner. Not sure yet how the delegating task should be displayed. Not against graying it out, but the total won't match the sum of the tasks (since tasks that "delegate" could take some milliseconds). Not sure if this really matters. Maybe we can write the time for the delegated task but gray it out?

What do you think?

(ping @gep13 @devlead)

[devlead]

Gray is nice, but as build server logs are just text might not clear enough. Maybe just report on diagnostic / verbose?

[patriksvensson]

@devlead Reports are not written to the log. They're written to the console.

[devlead]

Usually build servers display console output as log right?

[patriksvensson]

@devlead Yes, they are. But we're writing the report using IConsole (and not ICakeLog) beacuse we want to do "pretty printing" of the summary (using colors).

[devlead]

I understand that, colors rarely preserved on CI, so just an esthetic when running local then?

[patriksvensson]

@devlead Yes, exactly. So the question is if we:

1. Exclude "delegating" tasks (so they won't show up in either log)
2. Grey them out
3. Grey them out and add some description that tells the user that they just branched of to other tasks.

[devlead]

Ok, I would vote hide by verbosity so they're shown if diagnostic.

[patriksvensson]

@devlead That is a good idea.

@ErikSchierboom What do you think about that?

[ErikSchierboom]

Hiding by verbosity seems like a good idea! Should I only show the duration in gray, or also the task itself?

[devlead]

I think both. @patriksvensson ?

[patriksvensson]

@ErikSchierboom @devlead Maybe we need to think about this some more. I think we might get issues posted for this otherwise like BUG: Some tasks is not shown unless using diagnostic verbosity.

[patriksvensson]

@ErikSchierboom @devlead Maybe we need to add a description like we did with Skipped.

[patriksvensson]

OK, maybe we should just go with the one we agreed on and figure this out later? It's probably good 😄

[ErikSchierboom]

But what is the one we agreed on? The one with the verbosity? Or with the description?

[patriksvensson]

Sorry, I meant the one with verbosity.

[ErikSchierboom]

I've create a PR to implement this functionality. I believe that issue #123 is a duplicate of this one by the way.