-
-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for SHA256 code signing #685
Comments
I have the same problem. Even appening the required argument via the ArgumentBuilder isn't possible because the order of the arguments passed to signtool matters. A valid command line for signing a file with SHA256 looks like this:
A possible workaround is to prepare the correct argument string manually and call signtool.exe directly. |
@swanitzek You can slso return a new ProcessArgumentBuilder from the ArgumentCustomization lambda and rewrite all parameters that way. |
@patriksvensson, mind if I take a stab on this one? Needed to sign using sha256 today, and doing the ArgumentCustomization dance was a ugly workaround. |
@mholo65 Perfect I've assigned this issue to you. |
Big thanks to @mholo65 for implementing this! |
As of 1st January Microsoft no longer accepts SHA1 certificates for code signing.
The existing Sign code does not support SHA256 signing and timestamps.
The required options are:
The text was updated successfully, but these errors were encountered: