Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend SolutionParserResult with solution folders information #919

Closed
gpeto86 opened this issue May 25, 2016 · 4 comments
Closed

Extend SolutionParserResult with solution folders information #919

gpeto86 opened this issue May 25, 2016 · 4 comments
Labels
Milestone

Comments

@gpeto86
Copy link
Contributor

gpeto86 commented May 25, 2016

What You Are Seeing?

SolutionParser doesn't parse solution folders.

What is Expected?

SolutionParserResult should contain information about solution folders and the projects they contain.
It would be better if somehow the relationship between solution folders and projects is visible. So it should be more than just another collection property containing a list of solution folders.
Any suggestion?

What version of Cake are you using?

0.11.0

Are you running on a 32 or 64 bit system?

64 bit

What environment are you running on? Windows? Linux? Mac?

Windows

Are you running on a CI Server? If so, which one?

Not yet.

@gpeto86 gpeto86 changed the title Extend SolutionParser with solution folders information Extend SolutionParserResult with solution folders information May 25, 2016
@gpeto86
Copy link
Contributor Author

gpeto86 commented May 26, 2016

I have taken a look into the affected code.
Current
SolutionParserResultcontains a readonly collection of SolutionProject (line 42 - link) and SolutionParser explicitly ignores projects with SolutionFolder type (line 76 - link).

Suggestion
A new class would be introduced (SolutionFolder) and it would be inherited from SolutionProject as it's actually is and would have a collection of SolutionProject as child items. SolutionProject would be extended with a Parent property pointing to the SolutionFolder if any.
SolutionParserResult would contain instances of both SolutionProject and SolutionFolder, either in one collection or separately.

@devlead
Copy link
Member

devlead commented May 29, 2016

@endrton could bea nice addition 👍, if you have the opportunity to do a pr, please do and we can continue discussion there.

@gep13
Copy link
Member

gep13 commented Jun 2, 2016

This issue is being worked on by @endrton

@gep13 gep13 added the Feature label Jul 18, 2016
@gep13 gep13 added this to the v0.15.0 milestone Jul 18, 2016
gep13 added a commit that referenced this issue Jul 18, 2016
gep13 added a commit that referenced this issue Jul 18, 2016
@gep13
Copy link
Member

gep13 commented Jul 18, 2016

@endrton thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants