Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in parameters.cake not checking IsRunningOnAppVeyor correctly #941

Closed
devlead opened this issue Jun 2, 2016 · 1 comment
Closed

Typo in parameters.cake not checking IsRunningOnAppVeyor correctly #941

devlead opened this issue Jun 2, 2016 · 1 comment
Assignees
@devlead
Labels
Build
Milestone
v0.13.0

Comments

@devlead
Copy link
Member

devlead commented Jun 2, 2016

This won't check if running on AppVeyor 😊
https://github.com/cake-build/cake/blob/develop/build/parameters.cake#L59

IsRunningOnAppVeyor = context.IsRunningOnWindows(),

PR coming shortly.
devlead added a commit to devlead/cake that referenced this issue Jun 2, 2016
@devlead
Fixes invalid AppVeyor check in parameters.cake
ff13b24 
* Fixes cake-build#941
@patriksvensson
Copy link
Member

Lol! 😄

@devlead devlead mentioned this issue Jun 2, 2016
Merged
@gep13 gep13 added this to the v0.13.0 milestone Jun 2, 2016
@gep13 gep13 added the Bug label Jun 2, 2016
@gep13 gep13 closed this as completed in #942 Jun 2, 2016
gep13 added a commit that referenced this issue Jun 2, 2016
@gep13
Merge pull request #942 from devlead/feature/GH-941
999c319 
Fixes invalid AppVeyor check in parameters.cake
@patriksvensson patriksvensson added Build and removed Bug labels Jun 2, 2016
@gep13 gep13 added Bug and removed Build labels Jun 7, 2016
@patriksvensson patriksvensson added Build and removed Bug labels Jun 7, 2016
@gep13 gep13 added Build and removed Build labels Jun 7, 2016
@gep13 gep13 modified the milestone: v0.13.0 Jun 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devlead devlead

Labels
Build
Projects
None yet
Milestone
v0.13.0
Development

No branches or pull requests
3 participants
@patriksvensson @gep13 @devlead