GH1002: Make sure that cake.config can be found #1003
Conversation
|
Hi @patriksvensson, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
|
@patriksvensson looks like there is a failing test on Mono :-( |
|
@gep13 Ouch! Will take a look at it during my lunch. |
| public IDictionary<string, string> Arguments { get; set; } | ||
|
|
||
| public CakeConfigurationProviderFixture() | ||
| { | ||
| Environment = FakeEnvironment.CreateUnixEnvironment(); | ||
| FileSystem = new FakeFileSystem(Environment); | ||
| Path = "./"; |
There was a problem hiding this comment.
use Environment.CurrentDirectory()?
There was a problem hiding this comment.
Ah, no. This is a unit test fixture.
|
Seems like there's a mono bug in NSubstitute. |
Oh no! 😢 |
For some reason, we used the working directory to locate the cake.config which works fine if the script that is being executed resides in the root directory. This commit will make sure that Cake always will look for cake.config in the same directory as the build script. Closes #1002
|
Ok, I've fixed the problem and rebased against develop 😄 |
|
LGTM! 😄 |
patriksvensson
changed the title
For some reason, we used the working directory to locate the cake.config which works fine if the script that is being executed resides in the root directory. This PR will make sure that Cake always will look for cake.config in the same directory as the build script.
Closes #1002