GH1025: Replace the command line argument switches for GitVersion #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @asbjornu, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
Replace slash with dash in the command line argument switches for gitversion.exe, so it is more Unix friendly. It will still fail exeucting on OS X due to GitTools/GitVersion#890, but once that has been fixed, this should ensure that GitVersion executes successfully on OS X.
asbjornu
force-pushed
the
feature/gitversion-command-line-switches
branch
from
ffdb7fb to
4b0b47b
Compare
asbjornu
added a commit
to asbjornu/NUnit.System.Linq
that referenced
this pull request
Jun 30, 2016
|
This is related to #1025 |
|
@asbjornu this makes sense to me, and explains why I was seeing errors in the GitVersion build on Travis. |
asbjornu
added a commit
to asbjornu/NUnit.System.Linq
that referenced
this pull request
Jun 30, 2016
|
@cake-build/team I am going to go ahead and merge this, even though the Travis build failed, as there is a known issue with Travis. |
|
@gep13 Excellent, thanks! |
gep13
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces slash with dash in the command line argument switches for
gitversion.exe, so it is more Unix friendly. It will still fail exeucting on OS X due to GitTools/GitVersion#890, but once that has been fixed, this should ensure that GitVersion executes successfully on OS X.