Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected documentation for InspectCode Alias #1026

Merged
merged 1 commit into from
Jul 1, 2016
Merged

Corrected documentation for InspectCode Alias #1026

merged 1 commit into from
Jul 1, 2016

Conversation

pmiossec
Copy link
Contributor

@pmiossec pmiossec commented Jul 1, 2016

Replace ';' by ',' in C# object initializer

@dnfclas
Copy link

dnfclas commented Jul 1, 2016

Hi @pmiossec, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

devlead
devlead reviewed Jul 1, 2016
View reviewed changes
src/Cake.Common/Tools/InspectCode/InspectCodeAliases.cs
/// Profile = "./MySolution.sln.DotSettings",
/// MsBuildProperties = msBuildProperties,
/// OutputFile = resharperReportsDirectory + File("inspectcode-output.xml"),
/// ThrowExceptionOnFindingViolations = true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last coma can be trimmed.

@pmiossec
Fix InspectCode documentation
3150fb9 
Replace ';' by ',' in C# object initializer
@devlead
Copy link
Member

devlead commented Jul 1, 2016

@pmiossec LGTM 👍. Left a minor comment, adjust, squash/rebase commit and I'll merge:+1:

@pmiossec
Copy link
Contributor Author

pmiossec commented Jul 1, 2016

done

On 1 July 2016 at 22:33, Mattias Karlsson notifications@github.com wrote:

@pmiossec https://github.com/pmiossec LGTM 👍. Left a minor comment,
adjust, squash/rebase commit and I'll merge👍

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1026 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAcFpNKDf7_xQVDWqX1FWvjCDdMmmvCSks5qRXmegaJpZM4JDczD
.

@devlead devlead merged commit 5aace32 into cake-build:develop Jul 1, 2016
@devlead
Copy link
Member

devlead commented Jul 1, 2016

@pmiossec merged, thanks for contributing 👍

@pmiossec
Copy link
Contributor Author

pmiossec commented Jul 1, 2016

No problems ;)
Continue the good work!

@pmiossec pmiossec deleted the fix_inspectcode_doc branch July 3, 2016 14:43
@gep13 gep13 changed the title Fix InspectCode documentation Corrected documentation for InspectCode Alias Jul 11, 2016
@gep13 gep13 added this to the v0.14.0 milestone Jul 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v0.14.0
Development

Successfully merging this pull request may close these issues.
4 participants
@pmiossec @dnfclas @devlead @gep13