NOT REQUIRED: Adding a sample with multiple arguments #1043
Conversation
This might be obvious, but because of the nature of a cake script (currently no intellisense) I needed some minutes to understand what the ArgumentCustomization is doing and how I can append two or more arguments.
|
Hi @robertmuehsig, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
| @@ -39,6 +39,10 @@ public class ToolSettings | |||
| /// new NuGetSourcesSettings { UserName = "user", Password = "incorrect", | |||
| /// ArgumentCustomization = args=>args.Append("-StorePasswordInClearText") | |||
| /// }); | |||
| /// // or with multiple arguments: | |||
| /// MSTest(pathPattern, new MSTestSettings() { ArgumentCustomization = args => { args.Append("/detail:errormessage"); | |||
There was a problem hiding this comment.
@robertmuehsig thanks for adding this, I think it makes a lot of sense. One comment though...
Can you change the > to be > as per the first example, otherwise bad things happen 😄
|
@robertmuehsig this can actually be simplified as you'll get a builder back you can just MSTest(pathPattern,
new MSTestSettings {
ArgumentCustomization = args => args.Append("/detail:errormessage")
.args.Append("/resultsfileTestResults.trx")});Written on phone so might not 100% correct & formatted, but hopefully you get the gist of it 😉 |
|
@robertmuehsig looks like there are a couple StyleCop errors related to this PR. You can see the build log here: https://ci.appveyor.com/project/cakebuild/cake/build/0.14.0-PullRequest.1043+55.build.2315 Any chance you can fix them up? Thanks! |
|
Also would prefer if multiple samples were divided info paragraphs like below |
|
Mhh... I will take a look at it later and resolve the StyleCop issues and provide multiple examples. Thanks guys! :) |
| @@ -39,6 +39,9 @@ public class ToolSettings | |||
| /// new NuGetSourcesSettings { UserName = "user", Password = "incorrect", | |||
| /// ArgumentCustomization = args=>args.Append("-StorePasswordInClearText") | |||
| /// }); | |||
| /// // or with multiple arguments: | |||
| /// MSTest(pathPattern, new MSTestSettings() { ArgumentCustomization = args => args.Append("/detail:errormessage") | |||
| /// .Append("/resultsfile:TestResults.trx") }); | |||
There was a problem hiding this comment.
We use spaces not tabs
so that's likely the stylecop issue.
|
Close because I created a new PR #1047 |
Was there something wrong with this one? |
|
Well - TBH - I started this PR via the GitHub Web UI (thats why the tabs instead of the spaces) and decided to start over on my workmachine because I thought it would be easier to not fightling against the git commands. |
Oh, absolutely, I just wanted to make sure that everything was ok. Git, GitHub and Pull Requests are very clever once you get your head around them, Even if you think things are very broken, there are likely things that can be done to correct them, so opening a new PR is not always necessary. In this instance, creating a new PR is a perfectly valid approach. Like I say, just wanted to make sure that everything was ok 😄 |
gep13
changed the title
This might be obvious, but because of the nature of a cake script (currently no intellisense) I needed some minutes to understand what the ArgumentCustomization is doing and how I can append two or more arguments.