Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH957 GH1010: Enhance docs for DotNetCore and GitReleaseManager aliases. #1056

Merged
merged 2 commits into from
Jul 14, 2016

Conversation

luisgoncalves
Copy link
Contributor

This fixes #957 and #1010. It's my first contribution; let me know if everything is OK.

@dnfclas
Copy link

dnfclas commented Jul 14, 2016

Hi @luisgoncalves, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@gep13
Copy link
Member

gep13 commented Jul 14, 2016

@luisgoncalves this looks great to me! Thank you for the contribution! Are you in a position to sign the CLA that is linked above? If you can do that, I will go ahead and get this merged.

@gep13 gep13 added this to the v0.15.0 milestone Jul 14, 2016
@gep13 gep13 removed this from the v0.15.0 milestone Jul 14, 2016
@gep13 gep13 changed the title Enhance docs for DotNetCore and GitReleaseManager aliases. GH957 GH1010: Enhance docs for DotNetCore and GitReleaseManager aliases. Jul 14, 2016
@dnfclas
Copy link

dnfclas commented Jul 14, 2016

@luisgoncalves, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

@luisgoncalves
Copy link
Contributor Author

@gep13 done!

@gep13
Copy link
Member

gep13 commented Jul 14, 2016

@luisgoncalves perfect! 😄

@gep13 gep13 merged commit fa3ac45 into cake-build:develop Jul 14, 2016
@luisgoncalves luisgoncalves deleted the fix-docs branch July 15, 2016 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Corrected code example for DotNetCorePackSettings
3 participants