Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH1091: Fix issue where array types appearing in aliased methods ar… #1093

Merged
merged 1 commit into from
Jul 22, 2016

Conversation

kcamp
Copy link
Contributor

@kcamp kcamp commented Jul 21, 2016

This should resolve #1091 and provide sufficient test coverage for the same.
I have run the build script by which I uncovered this issue in both roslyn/mono mode, it succeeds in both cases.

…methods are not being generated correctly for re-compilation
@dnfclas
Copy link

dnfclas commented Jul 21, 2016

Hi @kcamp, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@devlead
Copy link
Member

devlead commented Jul 21, 2016

@kcamp LGTM 👍 in order to do final review and merge of this we need you to sign .NET Foundation CLA, you can do that at https://cla2.dotnetfoundation.org

@kcamp
Copy link
Contributor Author

kcamp commented Jul 21, 2016

@devlead -- working on that now. have a question in with my employer how it is to be handled. will sign tonight/tomorrow. thanks.

@devlead
Copy link
Member

devlead commented Jul 21, 2016

@kcamp superb 👍 , just ping us when done and we'll do a final review before merging.

@dnfclas
Copy link

dnfclas commented Jul 22, 2016

@kcamp, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

@kcamp
Copy link
Contributor Author

kcamp commented Jul 22, 2016

@devlead cla signed

@devlead devlead merged commit 0018659 into cake-build:develop Jul 22, 2016
@gep13 gep13 changed the title GH-1091 - Fix issue where array types appearing in aliased methods ar… GH1091: Fix issue where array types appearing in aliased methods ar… Jul 22, 2016
@devlead
Copy link
Member

devlead commented Jul 22, 2016

@kcamp LGTM 👍 your changes have now been merged, thanks for your contribution!

@kcamp kcamp deleted the GH-1091 branch July 22, 2016 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GetFullName in TypeExtensions.cs not handling arrays correctly
3 participants