GH1121: Add support for 'setParameter' service message to TeamCityProvider + … #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kcamp, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
|
Relates to #1121 |
gep13
changed the title
dbertram
pushed a commit
to dbertram/cake
that referenced
this pull request
Sep 2, 2016
… interface Support for TeamCity's "setParameter" service message was added in cake-build#1114 but only the tests and implementor were updated. This change updates the interface to match, which is what is actually exposed to Cake scripts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In working with a legacy build process (converting to Cake), I noticed the absence of a method exposing the setParameter service message in TeamCity.
see: https://confluence.jetbrains.com/display/TCD9/Build+Script+Interaction+with+TeamCity#BuildScriptInteractionwithTeamCity-AddingorChangingaBuildParameter
Given the current implementation of TeamCityProvider (WriteServiceMessage) this was a simple addition that seems like it would be useful to more fully support TeamCity interop.