GH703: Add FileLogger switches to MSBuild Runner #1215
Conversation
|
Hi @bradtwurst, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! TTYL, DNFBOT; |
|
@bradtwurst, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
Addresses issue cake-build#703 Provides the ability to add FileLogger parameters to the MsBuild command line. The various fileloggerparameters (flp) can also be specified. The parameters that can be created are /fl, /fl[1 thru 9], /flp, and /flp[1 thru 9]
bradtwurst
force-pushed
the
develop-msbuild-filelogger
branch
from
c742191
to
4d12531
Compare
There was a problem hiding this comment.
@bradtwurst Looks good to me. Have some required changes, but they are only related to grammar and code style. Great job!
| // Given | ||
| var fixture = new MSBuildRunnerFixture(false); | ||
| fixture.Settings.AddFileLogger(new MSBuildFileLogger { AppendToLogFile = false, Encoding = "E", HideVerboseItemAndPropertyList = false, LogFile = "A", MSBuildFileLoggerOutput = MSBuildFileLoggerOutput.All, PerformanceSummaryEnabled = false, ShowCommandLine = false, ShowEventId = false, ShowTimestamp = false, SummaryDisabled = false, Verbosity = Verbosity.Diagnostic }); | ||
|
|
| fixture.Settings.AddFileLogger(new MSBuildFileLogger { AppendToLogFile = false, Encoding = "E", HideVerboseItemAndPropertyList = false, LogFile = "A", MSBuildFileLoggerOutput = MSBuildFileLoggerOutput.All, PerformanceSummaryEnabled = false, ShowCommandLine = false, ShowEventId = false, ShowTimestamp = false, SummaryDisabled = false, Verbosity = Verbosity.Diagnostic }); | ||
|
|
||
| fixture.Settings.AddFileLogger(new MSBuildFileLogger { AppendToLogFile = true, HideVerboseItemAndPropertyList = true, MSBuildFileLoggerOutput = MSBuildFileLoggerOutput.ErrorsOnly, PerformanceSummaryEnabled = true, ShowCommandLine = true, ShowEventId = true, ShowTimestamp = true, SummaryDisabled = true, Verbosity = Verbosity.Minimal }); | ||
|
|
| fixture.Settings.AddFileLogger(new MSBuildFileLogger { AppendToLogFile = true, HideVerboseItemAndPropertyList = true, MSBuildFileLoggerOutput = MSBuildFileLoggerOutput.ErrorsOnly, PerformanceSummaryEnabled = true, ShowCommandLine = true, ShowEventId = true, ShowTimestamp = true, SummaryDisabled = true, Verbosity = Verbosity.Minimal }); | ||
|
|
||
| fixture.Settings.AddFileLogger(new MSBuildFileLogger { MSBuildFileLoggerOutput = MSBuildFileLoggerOutput.WarningsOnly, Verbosity = Verbosity.Normal }); | ||
|
|
| fixture.Settings.AddFileLogger(new MSBuildFileLogger { MSBuildFileLoggerOutput = MSBuildFileLoggerOutput.WarningsOnly, Verbosity = Verbosity.Normal }); | ||
|
|
||
| fixture.Settings.AddFileLogger(new MSBuildFileLogger { Verbosity = Verbosity.Quiet }); | ||
|
|
| fixture.Settings.AddFileLogger(new MSBuildFileLogger { Verbosity = Verbosity.Quiet }); | ||
|
|
||
| fixture.Settings.AddFileLogger(new MSBuildFileLogger { Verbosity = Verbosity.Verbose }); | ||
|
|
| { | ||
| throw new ArgumentNullException(nameof(fileLoggerParameters)); | ||
| } | ||
| settings.FileLoggers.Add(fileLoggerParameters); |
|
|
||
| /// <summary> | ||
| /// Adds a file logger with all the default settings. | ||
| /// |
| /// <summary> | ||
| /// Adds a file logger with all the default settings. | ||
| /// | ||
| /// each file logger will be declared in the order added |
There was a problem hiding this comment.
Sentence should begin with a capital letter and end with a period.
| /// Adds a file logger with all the default settings. | ||
| /// | ||
| /// each file logger will be declared in the order added | ||
| /// the first file logger will match up to the /fl parameter |
There was a problem hiding this comment.
Sentence should begin with a capital letter and end with a period.
| /// | ||
| /// each file logger will be declared in the order added | ||
| /// the first file logger will match up to the /fl parameter | ||
| /// the next nine (max) file loggers will match up to the /fl1 through /fl9 respectively |
There was a problem hiding this comment.
Sentence should begin with a capital letter and end with a period.
|
@bradtwurst I have rebased and merged this PR, and also added the PR Review comments from @patriksvensson. You can see this merged in here: 3dbf510 As a result, I am going to manually close this PR, but your contribution has been pulled in, and correctly attributed. Thank you for taking the time to contribute to cake! 👍 |
Addresses issue #703
Provides the ability to add FileLogger parameters to the MsBuild command
line. The various fileloggerparameters (flp) can also be specified.
The parameters that can be created are /fl, /fl[1 thru 9], /flp, and
/flp[1 thru 9]