Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds default CPU count behavior to MSBuild settings documentation #1234

Merged
merged 1 commit into from
Sep 17, 2016
Merged

Adds default CPU count behavior to MSBuild settings documentation #1234

merged 1 commit into from
Sep 17, 2016

Conversation

phil-scott-78
Copy link
Contributor

Default behavior without setting the MaxCpuCount will be to compile
projects one at a time. The documentation indicated how to set this to use
all your processors, but didn't indicate the behavior if you didn't.
Because the value of 0 means use all available CPUs I suspect many people
like myself would think that 0 is the default so no value was needed to be
explicitly specified.

See https://msdn.microsoft.com/en-us/library/bb651793.aspx

Default behavior without setting the MaxCpuCount will be to compile
projects one at a time. The documentation indicated how to set this to use
all your processors, but didn't indicate the behavior if you didn't.
Because the value of 0 means use all available CPUs I suspect many people
like myself would think that 0 is the default so no value was needed to be
explicitly specified.
@dnfclas
Copy link

dnfclas commented Sep 16, 2016

Hi @enkafan, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@dnfclas
Copy link

dnfclas commented Sep 16, 2016

@enkafan, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

@gep13 gep13 added this to the v0.17.0 milestone Sep 17, 2016
@gep13 gep13 changed the title Adds default CPU count behavior to MSBuild settings documentation [DOC] Adds default CPU count behavior to MSBuild settings documentation Sep 17, 2016
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit 127bff7 into cake-build:develop Sep 17, 2016
@gep13
Copy link
Member

gep13 commented Sep 17, 2016

@enkafan thank you for your contribution!

@gep13 gep13 changed the title [DOC] Adds default CPU count behavior to MSBuild settings documentation Adds default CPU count behavior to MSBuild settings documentation Oct 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants