GH1247: Change to use AnyCPU to address Mono issue #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So @cake-build/team & @Redth
This PR removes the mono framework prefixing in integration tests which is confirmed by the diagnostic log ========================================
Cake.Common.Tools.Cake.CakeAliases.CakeExecuteScript
========================================
Executing task: Cake.Common.Tools.Cake.CakeAliases.CakeExecuteScript
Executing: /home/matkar/monocakescriptissue/cake/tests/integration/tools/Cake/Cake.exe "/home/matkar/monocakescriptissue/cake/tests/integration/resources/Cake.Common/Tools/Cake/build.cake"
Finished executing task: Cake.Common.Tools.Cake.CakeAliases.CakeExecuteScript
========================================
Cake.Common.Tools.Cake.CakeAliases.CakeExecuteScript.Settings.Ok
========================================
Executing task: Cake.Common.Tools.Cake.CakeAliases.CakeExecuteScript.Settings.Ok
Executing: /home/matkar/monocakescriptissue/cake/tests/integration/tools/Cake/Cake.exe "/home/matkar/monocakescriptissue/cake/tests/integration/resources/Cake.Common/Tools/Cake/test.cake" -ok="yes"
Finished executing task: Cake.Common.Tools.Cake.CakeAliases.CakeExecuteScript.Settings.Ok
========================================
Cake.Common.Tools.Cake.CakeAliases.CakeExecuteScript.Settings.NotOk
========================================
Executing task: Cake.Common.Tools.Cake.CakeAliases.CakeExecuteScript.Settings.NotOk
Executing: /home/matkar/monocakescriptissue/cake/tests/integration/tools/Cake/Cake.exe "/home/matkar/monocakescriptissue/cake/tests/integration/resources/Cake.Common/Tools/Cake/test.cake" -ok="no"
Finished executing task: Cake.Common.Tools.Cake.CakeAliases.CakeExecuteScript.Settings.NotOk
========================================
Cake.Common.Tools.Cake.CakeAliases.CakeExecuteExpression
========================================
Executing task: Cake.Common.Tools.Cake.CakeAliases.CakeExecuteExpression
Executing: /home/matkar/monocakescriptissue/cake/tests/integration/tools/Cake/Cake.exe "/home/matkar/monocakescriptissue/cake/tests/integration/c497a5df-be2d-4a91-8373-47d3ce82ccb9.cake"
Finished executing task: Cake.Common.Tools.Cake.CakeAliases.CakeExecuteExpression
========================================
Cake.Common.Tools.Cake.CakeAliases.CakeExecuteExpression.Settings.Ok
========================================
Executing task: Cake.Common.Tools.Cake.CakeAliases.CakeExecuteExpression.Settings.Ok
Executing: /home/matkar/monocakescriptissue/cake/tests/integration/tools/Cake/Cake.exe "/home/matkar/monocakescriptissue/cake/tests/integration/0d8dbaa3-eded-4baf-ac74-a371ad0742c2.cake" -ok="yes"
Finished executing task: Cake.Common.Tools.Cake.CakeAliases.CakeExecuteExpression.Settings.Ok
========================================
Cake.Common.Tools.Cake.CakeAliases.CakeExecuteExpression.Settings.NotOk
========================================
Executing task: Cake.Common.Tools.Cake.CakeAliases.CakeExecuteExpression.Settings.NotOk
Executing: /home/matkar/monocakescriptissue/cake/tests/integration/tools/Cake/Cake.exe "/home/matkar/monocakescriptissue/cake/tests/integration/d86579d2-4618-4a53-ac79-c76cd1c7cdd1.cake" -ok="no"
Finished executing task: Cake.Common.Tools.Cake.CakeAliases.CakeExecuteExpression.Settings.NotOkTo confirm fix i downloaded v16.1 artifacts form last integration test ( https://ci.appveyor.com/api/buildjobs/sbpo9nvvjjy2pgmr/artifacts/Cake-bin-net45-v0.16.1.zip ) and did same procedure as above and it as expected failed: So this PR is ready for review. |
gep13
reviewed
Oct 10, 2016
| @@ -1,8 +1,9 @@ | |||
| { | |||
| "version": "0.16.1-*", | |||
| "version": "0.16.2-*", | |||
There was a problem hiding this comment.
@devlead doesn't this change need to happen in a number of files? Not just the top level one?
There was a problem hiding this comment.
Think that'll be patched by build.cake&GitVersion during build. As AppVeyor PR artifacts all v0.17.0 both nuget & assemblies, hopefully hotfix branch will get correct versioning once PR merged :)
There was a problem hiding this comment.
@devlead the reason that I ask is that in the last PR you did for 0.16.1, you updated all the files 😄
There was a problem hiding this comment.
But sure I can address that :)
devlead
force-pushed
the
feature/GH-1230
branch
from
29ada4e to
e604169
Compare
patriksvensson
requested changes
Oct 10, 2016
| "buildOptions": { | ||
| "emitEntryPoint": true, | ||
| "xmlDoc": true, | ||
| "platform": "AnyCpu", |
There was a problem hiding this comment.
I think change should be added to all assemblies.
devlead
force-pushed
the
feature/GH-1230
branch
from
e604169 to
a4185cf
Compare
This fixes cake-build#1247, because issue in .NET Core tooling AnyCPU needs to be specified
devlead
force-pushed
the
feature/GH-1230
branch
from
a4185cf to
a4c5586
Compare
gep13
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1247, because issue in .NET Core tooling AnyCPU needs to be specified