Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH1289: Sets the user agent for HTTP aliases, #1289 #1290

Merged
merged 1 commit into from
Oct 17, 2016
Merged

GH1289: Sets the user agent for HTTP aliases, #1289 #1290

merged 1 commit into from
Oct 17, 2016

Conversation

daveaglick
Copy link
Member

#1289

Implements a method to get a new HttpClient with the User-Agent header set to "Cake" and the current Cake version for all HTTP aliases.

@daveaglick daveaglick changed the title Sets the user agent for HTTP aliases, #1289 GH1289: Sets the user agent for HTTP aliases, #1289 Oct 17, 2016
devlead
devlead approved these changes Oct 17, 2016
View reviewed changes
Copy link
Member

@devlead devlead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@devlead devlead merged commit 2f0bf88 into cake-build:develop Oct 17, 2016
@devlead
Copy link
Member

devlead commented Oct 17, 2016

@daveaglick your changes has now been merged, thanks for contributing 👍

@devlead devlead mentioned this pull request Oct 17, 2016
Closed
@daveaglick daveaglick deleted the GH1289 branch October 19, 2016 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devlead devlead devlead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daveaglick @devlead @dnfclas