GH1734: Add GitLink 3 aliases #1735
Conversation
|
@Cheesebaron, |
|
This will be a breaking change for anyone not using GitLink 3.0, right? Any possibility to introduce a GitLink3-runner or similar? |
|
@patriksvensson correct. This could be made as a different runner and alias. I have no issue with doing that instead. @devlead will fix that. |
|
Agree with @patriksvensson, could you keep old aliases and add new 3 editions |
|
Should the AliasCategory still be GitLink or a separate GitLink3 one instead? |
|
|
|
Done. Old Gitlink stuff is as is. I've added version pinning in the XML docs for the v2 stuff. I've renamed all the new GitLink stuff to GitLink3 and made a category called GitLink v3, similar to NUnit. |
There was a problem hiding this comment.
@Cheesebaron builds are failing. Could you try running build scripts locally before pushing changes? .\build.ps1 on Windows or .\build.sh on Linux/OSX.
Tests seems to be hanging, I can see that e.g. TeamCity build times out after 4h running!
| /// <para> | ||
| /// In order to use the commands for this alias, include the following in your build.cake file to download and | ||
| /// install from NuGet.org, or specify the ToolPath within the <see cref="GitLink3Settings" /> class: | ||
| /// <code> |
There was a problem hiding this comment.
Malformed Xml. Remove the extra <para> above.
There was a problem hiding this comment.
There was a problem hiding this comment.
@mholo65 sooooo I just copied what was in: https://github.com/cake-build/cake/blob/develop/src/Cake.Common/Tools/GitLink/GitLinkAliases.cs#L13 it is the same... except I added version 3 after the closing see tag.
There was a problem hiding this comment.
I see, it seems to be complaining about version
Tools\GitLink\GitLinkAliases.cs(18,38): error CS1570: XML comment has badly formed XML -- 'version'
On second glimpse, to me that XML looks fine.
There was a problem hiding this comment.
I've fixed it. The ampersand needed escaping
|
@devlead & @mholo65 anything else you guys want me to change? I think I have addressed both the issues you pointed out. I've rebased the PR so many times now, I can rebase it again when you think it is ready to merge. |
gep13
changed the title
bjorkstromm
changed the title
|
@Cheesebaron your changes have been merged, thanks for your contribution 👍 |
This Pull Request relates to #1734 and updates the GitLink tool to reflect the major restructure that was done in GitLink 3.0.0.
Instead of taking a solution directory, the new GitLink tool takes singular pdb files and patches them. I've added a helper alias to allow passing a FilePathCollection to allow globbing.