Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH1771: Look for msbuild in default install path on Linux #1749

Merged
merged 2 commits into from
Aug 30, 2017

Conversation

atsushieno
Copy link
Contributor

It is almost the same way as 3046320 did for Mac.

@dnfclas
Copy link

dnfclas commented Aug 14, 2017

@atsushieno,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@atsushieno
Copy link
Contributor Author

( This is one of the issues I mentioned at #1733 )

It is almost the same way as 3046320 did for Mac.
@devlead devlead force-pushed the fix-linux-msbuild-invocation branch from ae8f277 to a5eecd8 Compare August 29, 2017 05:37
@devlead devlead changed the title Look for msbuild in default install path on Linux GH1733: Look for msbuild in default install path on Linux Aug 29, 2017
@devlead devlead changed the title GH1733: Look for msbuild in default install path on Linux GH1771: Look for msbuild in default install path on Linux Aug 29, 2017
@devlead
Copy link
Member

devlead commented Aug 29, 2017

Relates to #1771

@devlead devlead force-pushed the fix-linux-msbuild-invocation branch from 782bea7 to 90ea542 Compare August 30, 2017 18:35
@devlead devlead force-pushed the fix-linux-msbuild-invocation branch from 90ea542 to 35d6258 Compare August 30, 2017 20:47
Copy link
Member

@devlead devlead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@devlead devlead merged commit 35d6258 into cake-build:develop Aug 30, 2017
@devlead
Copy link
Member

devlead commented Aug 30, 2017

@aateeque your changes have been merged, thanks for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants