Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH1796: Obsolete DotNet aliases #1965

Merged
merged 1 commit into from
Dec 18, 2017
Merged

Conversation

bjorkstromm
Copy link
Member

Copy link
Member

@devlead devlead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I'll merge once CI finishes.

@devlead devlead merged commit 48d28cf into cake-build:develop Dec 18, 2017
@devlead
Copy link
Member

devlead commented Dec 18, 2017

@mholo65 your changes have been merged, thanks for your contribution 👍

@@ -49,6 +50,7 @@ public static void DotNetBuild(this ICakeContext context, FilePath solution)
/// <param name="solution">The solution.</param>
/// <param name="configurator">The configurator.</param>
[CakeMethodAlias]
[Obsolete("Use MSBuild or XBuild instead.")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this give a warning or error message?

@devlead
Copy link
Member

devlead commented Dec 18, 2017

Warning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants