GH2039: Fix XUnit2Settings + XUnit2Runner to honor ParallelismOption.None #2040
+7
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcamp
changed the title
…t specifications of ParallelismOption.None
devlead
approved these changes
Mar 13, 2018
|
@kcamp your changes have been merged, thanks for your contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the first pass over what I believe to be the most appropriate fix for GH-2039.
I've made the property on the
XUnit2Settingsclass nullable.By default, assuming a user hasn't set the value, it will not be emitted as an argument.
This maintains parity with the previous implementation where
ParallelismOptions.None, the CLR default, would suppress the emission. In either case, no explicit argument will allow the runner to use the default.The other option that I entertained that we could explore further would be setting the default on the
XUnit2Settingsclass toCollectionsto match the runner, but I think this has the potential to create regressions for people.Please feel free to suggest other implementations if they're more desirable.