Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH3069: Remove use of UseWorkingDirectory in default template #3070

Conversation

pascalberger
Copy link
Member

Remove call to UseWorkingDirectory in Frosting default template, since we should not promote its usage as it can lead to some known issues.

Fixes #3069

Copy link
Member

@devlead devlead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@devlead devlead changed the title (GH-3069) Remove use of UseWorkingDirectory in default template GH3069: Remove use of UseWorkingDirectory in default template Feb 1, 2021
@devlead devlead disabled auto-merge February 1, 2021 20:51
@devlead devlead merged commit ba21d16 into cake-build:release/1.0.0 Feb 1, 2021
@devlead
Copy link
Member

devlead commented Feb 1, 2021

@pascalberger your changes have been merged, thanks for your contribution 👍

@pascalberger pascalberger deleted the feature/remove-useworkingdirectory branch February 1, 2021 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants