Support spaces in MSBuild configuration #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -61,8 +61,14 @@ private ProcessArgumentBuilder GetArguments(FilePath solution, MSBuildSettings s | |||
| if (!string.IsNullOrWhiteSpace(settings.Configuration)) | |||
| { | |||
| // Add the configuration as a property. | |||
| var configuration = settings.Configuration; | |||
| builder.Append(string.Concat("/p:Configuration=", configuration)); | |||
| if (settings.Configuration.Contains(" ")) | |||
There was a problem hiding this comment.
No need for this check. Instead, always append quoted.
|
@SharpeRAD Great. Left a comment for you. |
|
Done 😄 |
|
@SharpeRAD looks good 👍 could you rebase into 1 commit please. |
|
Done 😄 |
|
@SharpeRAD merged, thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an error I'm getting in a project that used to build correctly with Cake.
Build
Executing task: Build
Building Ex2007 SP3 from C:/Projects/Exchange.RemoveSection/src/RemoveSection.sln
Executing: C:/Program Files (x86)/MSBuild/14.0/Bin/amd64/MSBuild.exe /m /v:normal /p:Configuration=Ex2007 SP3 /p:Platform="Any CPU" /p:TreatWarningsAsErrors=true /target:Build "C:/Projects/Exchange.RemoveSection/src/RemoveSection.sln"
Microsoft (R) Build Engine version 14.0.23107.0
Copyright (C) Microsoft Corporation. All rights reserved.
MSBUILD : error MSB1008: Only one project can be specified.
Switch: C:/Projects/Exchange.RemoveSection/src/RemoveSection.sln
For switch syntax, type "MSBuild /help"
An error occured when executing task 'Build'.