Disable Quoting of process filename on unix #560
Merged
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great! 👍 Can we also add unit tests for this as well here? |
| @@ -48,13 +48,16 @@ public IProcess Start(FilePath filePath, ProcessSettings settings) | |||
| throw new ArgumentNullException("settings"); | |||
| } | |||
|
|
|||
| // Get the fileName | |||
| var fileName = _environment.IsUnix() ? filePath.FullPath : filePath.FullPath.Quote(); | |||
There was a problem hiding this comment.
This variable name confused me a little since it's the whole path that this contains and not just the file name. Maybe we can change this to fullFileName or something that shows that this is the full path to the file?
There was a problem hiding this comment.
Same name as ProcessStartInfo constructor parameter. Suggest we keep.
|
@devlead I read the code again and no tests are necessary for this one. It would require an integration test so let's just verify that it works for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #559