Alias examples for Net/Tools added - issue #750 #790
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cake.Common.Net.DownloadFile(string) Cake.Common.Net.DownloadFile(Uri) Cake.Common.Net.DownloadFile(string, FilePath) Cake.Common.Net.DownloadFile(Uri, FilePath) Cake.Common.Tools.DotNetBuild(FilePath) Cake.Common.Tools.DotNetBuild(FilePath, Action<DotNetBuildSettings>)
This was referenced Mar 27, 2016
|
@UnbelievablyRitchie looks good to me, could you squash commits and rebase against latest develop. |
|
Still learning git and managed to completely knacker this PR with an accidental merge instead of squash/rebase. Apologies. Do you want me to close and i'll reopen a new PR once sorted? ta. |
|
@UnbelievablyRitchie not a problem at all. When submitting to feedback on a PR, hopefully the steps outlined here can help: If not, we can extend the documentation if there is something that isn't clear. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've completed the following example entries as per #750 and I'd like a sanity/formatting check on these before continuing down the list:
Cake.Common.Net.DownloadFile(string)
Cake.Common.Net.DownloadFile(Uri)
Cake.Common.Net.DownloadFile(string, FilePath)
Cake.Common.Net.DownloadFile(Uri, FilePath)
Cake.Common.Tools.DotNetBuild(FilePath)
Cake.Common.Tools.DotNetBuild(FilePath, Action)
I believe the Start Process entry at the top of #750 list can be ticked too as it has an example already?
Thanks.