Adjusted MSTest tool resolution #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
devlead
commented
Apr 15, 2016
devlead
commented
- Added fallback to check environment for VisualStudio path if not found in default location
- Fixed parameter typo for ArgumentNullException
- Fixes MSTest tool resolution fail if Visual Studio isn't in default location #823
|
@devlead I think this needs some tests as well. |
|
@patriksvensson fixing that now. As well as the failing test. |
| } | ||
|
|
||
| var root = new DirectoryPath(visualStudioCommonToolsPath).Combine("../IDE"); | ||
| return root.CombineWithFilePath("mstest.exe"); |
There was a problem hiding this comment.
Maybe we should use the PathCollapser here before returning.
|
@patriksvensson adjusted PR
|
|
@patriksvensson rebased against latest develop. |
* Added fallback to check environment for VisualStudio path if not found in default location * Fixes cake-build#823
|
@devlead Can you rebase this again? |
|
@patriksvensson it should already be rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.