Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Typos in XBuild docs #866

Merged
merged 1 commit into from
May 5, 2016
Merged

Conversation

ChrisMaddock
Copy link
Contributor

@ChrisMaddock ChrisMaddock commented May 5, 2016

Looks like the XBuild docs were copied from the MSBuild ones, and a few references missed. Did a similar pull request for others I noticed previously (#817) - did a full search this time, so this should cover all the rest!

@gep13
Copy link
Member

gep13 commented May 5, 2016

@ChrisMaddock nice one! Thanks for doing this work!

Is there any chance that you can rebase this PR against the current develop branch, so that I can merge it in. If not, let me know, and I can take care of it.

@ChrisMaddock
Copy link
Contributor Author

^^ @gep13 - Whoops - looks like I got that wrong. :-/ Will try and fix it.

@gep13
Copy link
Member

gep13 commented May 5, 2016

@ChrisMaddock ha ha, not a problem at all. Let me know how you get on, and if you need any help.

@ChrisMaddock
Copy link
Contributor Author

@gep13 - that looks better - sorry, I'm a mercurial-man through and through! Thanks!

@gep13
Copy link
Member

gep13 commented May 5, 2016

@ChrisMaddock said...
that looks better - sorry, I'm a mercurial-man through and through! Thanks!

Ha ha, not a problem at all! Don't worry, we will convert you :-D

@gep13 gep13 added this to the v0.12.0 milestone May 5, 2016
@gep13 gep13 merged commit 2a3f173 into cake-build:develop May 5, 2016
@gep13
Copy link
Member

gep13 commented May 5, 2016

NOTE: This was a documentation change, so didn't wait for builds to complete.

@ChrisMaddock ChrisMaddock deleted the XBuildDocsTypo branch May 5, 2016 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants