Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing GitVersion return values #909

Merged
merged 1 commit into from
May 22, 2016
Merged

Add missing GitVersion return values #909

merged 1 commit into from
May 22, 2016

Conversation

phenixdotnet
Copy link
Contributor

Added:

  • CommitsSinceVersionSource
  • CommitsSinceVersionSourcePadded
  • CommitDate

@phenixdotnet phenixdotnet mentioned this pull request May 22, 2016
Closed
@gep13
Copy link
Member

gep13 commented May 22, 2016

@phenixdotnet this looks good to me! Thanks for doing this work!

I have just tested this out on the build.cake file for Cake, along with the new debugging support that @mholo65 added, and I can confirm that this is all working as expected:

image

Thanks!

@gep13 gep13 merged commit ad8f3e1 into cake-build:develop May 22, 2016
@phenixdotnet
Copy link
Contributor Author

@gep13 @mholo65 : Debugging directly the cake files ? yeah ! 👍

@gep13
Copy link
Member

gep13 commented May 22, 2016

@phenixdotnet yip yip yip! :-D The support for that will be released in 0.12.0, but you can use it just now from the MyGet Feed if you wanted to take it for a spin :-D

@gep13 gep13 added this to the v0.12.0 milestone May 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
v0.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@phenixdotnet @gep13