Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build.sh: adding OutputDirectory command line argument to nuget commands #64

Closed
wants to merge 1 commit into from

Conversation

t081as
Copy link

@t081as t081as commented Nov 19, 2018

Due to a missing "-OutputDirectory" command line argument (nuget commands) in the build.sh file (that is present in the build.ps1 file) the behavior of the two files is different if a Nuget.config file exists in the project folder.

see https://gitlab.com/tobiaskoch/LinkTime/-/jobs/122604224

@Alex-Witkowski
Copy link

Thanks for this. Faced the same issue.
We should bring this PR in!

Alex-Witkowski
Alex-Witkowski approved these changes Oct 25, 2019
Copy link

@Alex-Witkowski Alex-Witkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does exactly what's needed to get the Mac/unix version running when a custom NuGet.config is present.

@gep13 gep13 closed this Nov 2, 2020
@gep13 gep13 deleted the branch cake-build:develop November 2, 2020 20:38
@pascalberger
Copy link
Member

We did some maintenance work on this repo which included removing of the develop branch which closed this PR.

@t081as Can you please create a new PR targeting master branch if this is still an issue for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants