Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation on the Cake for Rider plugin #1441

Merged
merged 1 commit into from
Jan 4, 2021

Conversation

nils-a
Copy link
Member

@nils-a nils-a commented Dec 25, 2020

As with the blog post, this is mostly information from the readme.

Things that need to be changed, after the release and before the merge:

  • There's a link (placeholder) to the plugin in the marketplace, that needs to be set correctly.

@nils-a
Copy link
Member Author

nils-a commented Dec 25, 2020

@pascalberger @gep13 could you please have a look at it?

Copy link
Member

@pascalberger pascalberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nils-a Thanks for this 👍

I added some comments. How does it look with IntelliSense support in Rider?

input/docs/integrations/editors/rider/index.cshtml Outdated Show resolved Hide resolved
input/docs/integrations/editors/rider/tasks-window.md Outdated Show resolved Hide resolved
input/docs/integrations/editors/rider/settings.md Outdated Show resolved Hide resolved
input/docs/integrations/editors/rider/settings.md Outdated Show resolved Hide resolved
input/docs/integrations/editors/rider/settings.md Outdated Show resolved Hide resolved
input/docs/integrations/editors/rider/settings.md Outdated Show resolved Hide resolved
input/docs/integrations/editors/rider/settings.md Outdated Show resolved Hide resolved
input/docs/integrations/editors/rider/settings.md Outdated Show resolved Hide resolved
input/docs/integrations/editors/rider/settings.md Outdated Show resolved Hide resolved
input/docs/integrations/editors/rider/index.cshtml Outdated Show resolved Hide resolved
@nils-a
Copy link
Member Author

nils-a commented Dec 25, 2020

@pascalberger thanks for the review - I will implement the changes.

There is currently no support for IntelliSense in Cake for Rider - I will add a page, similar to https://cakebuild.net/docs/integrations/editors/visualstudio/intellisense

@pascalberger pascalberger added the merge blocked PR should not be merged yet label Dec 26, 2020
@nils-a nils-a force-pushed the cake-rider/documentation branch from d6cf146 to 62106b1 Compare January 3, 2021 20:39
@nils-a
Copy link
Member Author

nils-a commented Jan 3, 2021

@pascalberger I have added the correct url to the plugin in the Marketplace and rebased.

We could, technically, merge this in as soon as the plugin version in the marketplace has been approved. From that point on it would be possible to use the link provided in this commit to download the pre-release version manually from the Marketplace and "install from disc".
@pascalberger , @gep13 what do you think?

@nils-a nils-a force-pushed the cake-rider/documentation branch 2 times, most recently from 15b376a to 10a5911 Compare January 3, 2021 22:42
@nils-a
Copy link
Member Author

nils-a commented Jan 3, 2021

@pascalberger I added your suggestions.

Copy link
Member

@pascalberger pascalberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and ready to be merged once extension is available

Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nils-a
Copy link
Member Author

nils-a commented Jan 4, 2021

I'll send a ping when the current uploaded version (0.1.0-alpha.1) was approved (and then probably do a rebase, too).

@nils-a
Copy link
Member Author

nils-a commented Jan 4, 2021

:shipit:

image

@nils-a nils-a changed the title [DO NOT MERGE] added documentation on the Cake for Rider plugin Added documentation on the Cake for Rider plugin Jan 4, 2021
@pascalberger pascalberger merged commit 9a7bf2f into cake-build:master Jan 4, 2021
@pascalberger
Copy link
Member

@nils-a your changes have been merged, thanks for your contribution 👍

@pascalberger pascalberger removed the merge blocked PR should not be merged yet label Jan 4, 2021
@nils-a nils-a deleted the cake-rider/documentation branch January 5, 2021 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants