Update buildsystem to Cake.Recipe 2.0.0

[nils-a]

Steps should include:

• Change pre-processor directive
• Pin to updated version of Cake - 0.38.4
• Remove input parameters which are no longer required, for example shouldRunGitVersion: true as this is now the default
• Update bootstrapper to include --bootstrap command
• Project is using an embedded icon
• Project is using a deterministic build - --target=Enable-DeterministicBuild
• Rename AppVeyor default target - AppVeyor -> CI
• Update GitVersion.yml file with the required changes for using new version of GitVersion
• Add CakeContrib.Guidelines Nuget Package and add PackageIcon to csproj
• Remove usage of nuspec file(s) for NuGet packages, instead, we will run DotNetCore-Pack
• Add shouldUseDeterministicBuilds: true parameter
• Check for usage of shouldRunCodecov: true which is not required anymore - this is new default
• Add Cake.Addin.Analyzer package
• Add settings.json file for VSCode
• Add dependabot config file
• Add GitHub Actions
• Switch to Cake.Tool rather than Cake.exe
• Switch to not running PR's on AppVeyor
• Check for trailing spaces in the TestCoverageFilter
• Ensure targeting netstandard2.0 for project and netcoreapp2.1 and netcoreapp3.1 for tests
• Ensure AppVeyor build image is using latest
• Fix broken unit tests
• Fix dupFinderExcludePattern for multi-targetting platforms

[gep13]

@nils-a are all of these taken from the list that we have in the Cake.Recipe issue, or have you found that you need to add others?

[nils-a]

@gep13 only copied from Cake.Recipe. Not added anything currently. (Will notify if anything new pops up :-))

But while you here.. :-)

Can you elaborate on "Switch to not running PR's on AppVeyor"? Is setting skip_branch_with_pr: true meant by that?

[gep13]

That would be great, thank you!

The thought process there is due to the inclusion of dependabot. If we do this on all repositories in the Cake-Contrib organisation, and they all at the same time get a PR to update a dependency, then this is going to swamp AppVeyor, which in the free version, only allows a single build at a time. By switching off PR's, and only allowing builds on the main branches, we can use GitHub Actions for PR's instead.

Yes, I believe that this addition would be all that is required, but perhaps @AdmiringWorm could confirm?

[nils-a]

I think skip_branch_with_pr: true will only suppress that PR are built twice. (Like: Once for the push in the branch and once for the pr.)

[AdmiringWorm]

@nils-a because of the branches whitelist, it won't be built on the dependabot branches either.
If this section in the appveyor yaml file wasn't specified: https://github.com/cake-contrib/Cake.7zip/blob/develop/.appveyor.yml#L9-L14

Then additional configurations would be needed, either to blacklist dependabot branches, or to whitelist a select few branches.

[nils-a]

@AdmiringWorm Thanks.

So there's actually nothing to do for that step here.

[AdmiringWorm]

Correct. There is nothing additional that needs to be done for that step in this repo.