Bump the `Cake.Core` package to 4.0.0 #124

raman-m · 2024-04-10T11:55:43Z

Fixes #123

Outdated version 1.0.0 of referenced Cake.Core package #123

This PR upgrades the Cake.Core version to 4.0.0 which was released on Nov 19, 2023.
With minor refactoring, with checking and fixing errors/warnings/messages of StyleCop and IDE code analyzers.

Description

Bumped Cake.Core to 4.0.0 and other packages to the latest versions, see commit 0407e04
Removed unsupported Cake.Addin.Analyzer, the latest version 0.1.3 was released on Mar 3, 2021, see commit acaa3f7
Fixed the first StyleCop warnings, see commits c44057a and c88a432
Added .editorconfig to the solution because it is best practice for code analysis, see commit 42aa7f7
Fixed Cake Contrib Guidelines analysis error CCG0008 related to usage of recommended tags, see commit 634170b
Setup code analysis and StyleCop having updated solution & project files, see commit bd71595
Fixed StyleCop warnings: SA1210 (2c473db), SA1518 (fb0c16a), SA1600 (3ed30e3) and SA0001 (f352054)
Fixed CSharp analysis messages for testing project: CS1591 (206cd63)
Followed IDE Code Analysis suggestion: CA1510 (1ffc8d3)
Followed IDE Code Analysis suggestions: IDE0017 (d559ded) and IDE0066 (778f866)
Disabled 2 features which are available in .NET 8 (C# 12) only by IDE Code Analysis suggestions: IDE0290 (c080309) and IDE0300 (9efd482)

Related Issue

Fixes Outdated version 1.0.0 of referenced Cake.Core package #123

Motivation and Context

This change is required because of #123
After major release of referenced packages, Cake.Core one in our case, the packs versions must be updated.

How Has This Been Tested?

To be provided...

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes. Note by @raman-m: No actual changes means no new tests.
All new and existing tests passed.

raman-m · 2024-04-10T12:05:01Z

@gep13 Hey Gary!

I’d appreciate it if you could find some time to review, merge into the develop branch, and then release the next version, please!

raman-m · 2024-04-19T10:47:53Z

@devlead Hello Mattias!
Do you know who maintains the repository currently?

Workflow status

1 workflow awaiting approval
This workflow requires approval from a maintainer.

raman-m · 2024-06-25T16:11:45Z

@gep13 Gary
@devlead Mattias
Another notification has been issued for a new release due to Cake 4.0. I am confident that my pull request is of sufficient quality to be merged and released.

raman-m · 2024-06-25T16:23:13Z

@gep13 @nmbro @Jericho @daveaglick @derhally @augustoproiete @Sharparam @devlead @larzw @RLittlesII @jokay
Hello everyone, I apologize for directly tagging all of you!
Could anyone inform me who currently owns this repository? Who is responsible for reviewing PRs and managing releases?
Thank you kindly for directing me to the appropriate GitHub individuals.

nmbro

changes look good at a glance.

I remember @pascalberger being pretty active in the cake-contrib repos

And for the love of everything holy - remember to squash if this gets merged :)

Source/Cake.Coveralls.Tests/Cake.Coveralls.Tests.csproj

nils-a · 2024-06-27T21:54:54Z

@raman-m thank you for the contribution.
I have spoken to @gep13 and I will start bringing this repo up-to-speed in the coming days.

However, rather than doing one big jump to Cake 4, I will do small steps and create intermediate releases for Cake 2.0 and 3.0 between.
I will do that, since there are people out there stuck on one version or another for different reasons..

If it's ok for you, I'll probably cherry-pick some of your commits along the way..

raman-m · 2024-07-02T14:30:03Z

@nils-a Hi Nils!

However, rather than doing one big jump to Cake 4, I will do small steps and create intermediate releases for Cake 2.0 and 3.0 between.

Indeed, releasing previous versions of Core is a sensible approach.

If it's ok for you, I'll probably cherry-pick some of your commits along the way..

That's fine! There's no need to cherry-pick. I'll rebase the feature branch following the official release for versions 2 and 3. However, do let me know if you require any assistance.

P.S. I will resolve conflicts later after the releases.

Source/Cake.Coveralls/Cake.Coveralls.csproj

nils-a · 2024-07-08T06:49:45Z

@raman-m it is done: I released Cake.Coveralls 3.0.0 which added support for Cake 3.0.0. If you like, you can start resolving conflicts, now. 😬 I hope I have not made too many changes that collide with this PR.

raman-m · 2024-07-08T11:52:10Z

Going to rebase the feature branch and resolve merge conflicts...

CCG0006: No '.editorconfig' found in folder-structure. Usage of '.editorconfig' is strongly recommended. See https://cake-contrib.github.io/CakeContrib.Guidelines/rules/ccg0006

CCG0008: Usage of tag 'addin' is recommended. See https://cake-contrib.github.io/

…spaces

…gs for the project. Editor Config -> New line preferences -> Insert Final Newline = true Note: All files should end with new line because of GitHub diff tool which highlights absent new line

XML docs for test classes are nor required

Each project should be configured to include an XML documentation file with the compiled output.

Disable warning in the project file.

… throwing a new exception instance

Disable IDE0290 because the feature is available in .NET 8 (C# 12) only

Disable IDE0300 because the feature is available in .NET 8 (C# 12) only

… declared in the file.

raman-m · 2024-07-08T15:19:09Z

@nils-a, if it's alright with you, I can implement the Visual Studio refactoring Quick Action, also known as "Convert to file-scoped namespace", across all C# files. File-scoped namespaces have been available since .NET 6 vs C# 10.
What are your thoughts?

P.S. FYI

The feature branch has been rebased onto cake-contrib:develop❕

nils-a · 2024-07-08T15:25:29Z

While I, personally, like it, I'd rather have @gep13 input on that question.
Also, if we're going to implement it, I'd rather have it as an individual PR.

So, no, for now let's not do that.

nils-a

LGTM!

raman-m · 2024-07-08T16:44:34Z

Should I close conversation threads?

nils-a · 2024-07-08T19:14:19Z

@raman-m your changes have been merged, thanks for your contribution 👍

I will fix two more issues, and then I will release the v4.0.0.

gep13 · 2024-07-08T19:23:20Z

@nils-a said...
While I, personally, like it, I'd rather have @gep13 input on that question.

I don't have any strong opinion either way. Personally, I don't really like it, but I am an old .NET Developer, who is stuck in their ways! Long live string.Format

@nils-a said...
Also, if we're going to implement it, I'd rather have it as an individual PR.

I think that this would be the correct approach.

raman-m · 2024-07-09T11:50:32Z

Thank you for merging it!
I am looking forward to the v4 release so I can enable and test the new version with the build script in my project.

raman-m mentioned this pull request Apr 12, 2024

#2034 More rapid CircleCI builds (Part 1) ThreeMammals/Ocelot#2045

Merged

nmbro approved these changes Jun 25, 2024

View reviewed changes

Source/Cake.Coveralls.Tests/Cake.Coveralls.Tests.csproj Show resolved Hide resolved

raman-m requested a review from nmbro June 26, 2024 12:18

nils-a reviewed Jul 8, 2024

View reviewed changes

Source/Cake.Coveralls/Cake.Coveralls.csproj Show resolved Hide resolved

raman-m added 18 commits July 8, 2024 17:35

Bump packages to the latest version

0836177

Remove unsupported Cake.Addin.Analyzer

886376c

SA1629: Documentation text should end with a period

ee7a8a0

SA1413: Use trailing comma in multi-line initializers

dd0da71

Add '.editorconfig'

5354365

CCG0006: No '.editorconfig' found in folder-structure. Usage of '.editorconfig' is strongly recommended. See https://cake-contrib.github.io/CakeContrib.Guidelines/rules/ccg0006

CCG0008: Usage of tag 'cake-build' is recommended.

4514ef1

CCG0008: Usage of tag 'addin' is recommended. See https://cake-contrib.github.io/

Setup code analysis and StyleCop

81833bd

SA1210: Using directives should be ordered alphabetically by the name…

a448635

…spaces

SA1518: The line endings at the end of a file do not match the settin…

47bc609

…gs for the project. Editor Config -> New line preferences -> Insert Final Newline = true Note: All files should end with new line because of GitHub diff tool which highlights absent new line

SA1600: Elements should be documented

1d562d9

XML docs for test classes are nor required

SA0001: XML comment analysis is disabled due to project configuration

7e31f85

Each project should be configured to include an XML documentation file with the compiled output.

CS1591: Missing XML comment for publicly visible type or member 'xxx'.

913710f

Disable warning in the project file.

CA1510: Use 'ArgumentNullException.ThrowIfNull' instead of explicitly…

cfecabf

… throwing a new exception instance

IDE0017: Object initialization can be simplified

9db703e

IDE0066: Use 'switch' expression

13040cd

IDE0290: Use primary constructor.

6668d09

Disable IDE0290 because the feature is available in .NET 8 (C# 12) only

IDE0300: Use collection expression for array.

79c2439

Disable IDE0300 because the feature is available in .NET 8 (C# 12) only

SA1649: The file name of a C# code file does not match the first type…

d4247b9

… declared in the file.

nils-a mentioned this pull request Jul 8, 2024

Re-Add Cake.Addin.Analyzer after it has been updated #155

Closed

SA1202: 'public' members should come before 'protected' members

50306ed

raman-m force-pushed the 123 branch from 4d86e39 to 50306ed Compare July 8, 2024 14:57

raman-m requested a review from nils-a July 8, 2024 15:26

raman-m mentioned this pull request Jul 8, 2024

(#121) Bump Cake references to v3.0.0 #151

Merged

9 tasks

nils-a enabled auto-merge July 8, 2024 16:38

nils-a disabled auto-merge July 8, 2024 16:39

nils-a enabled auto-merge (squash) July 8, 2024 16:40

nils-a approved these changes Jul 8, 2024

View reviewed changes

nils-a merged commit 29859a7 into cake-contrib:develop Jul 8, 2024
5 checks passed

raman-m mentioned this pull request Oct 3, 2024

Release 23.3.4 artifacts | +semver: patch ThreeMammals/Ocelot#2161

Merged

raman-m deleted the 123 branch October 3, 2024 19:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump the `Cake.Core` package to 4.0.0 #124

Bump the `Cake.Core` package to 4.0.0 #124

raman-m commented Apr 10, 2024 •

edited

Loading

raman-m commented Apr 10, 2024

raman-m commented Apr 19, 2024 •

edited

Loading

raman-m commented Jun 25, 2024

raman-m commented Jun 25, 2024

nmbro left a comment •

edited

Loading

nils-a commented Jun 27, 2024

raman-m commented Jul 2, 2024

nils-a commented Jul 8, 2024

raman-m commented Jul 8, 2024

raman-m commented Jul 8, 2024 •

edited

Loading

nils-a commented Jul 8, 2024

nils-a left a comment

raman-m commented Jul 8, 2024

nils-a commented Jul 8, 2024

gep13 commented Jul 8, 2024

raman-m commented Jul 9, 2024

Bump the Cake.Core package to 4.0.0 #124

Bump the Cake.Core package to 4.0.0 #124

Conversation

raman-m commented Apr 10, 2024 • edited Loading

Fixes #123

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

raman-m commented Apr 10, 2024

raman-m commented Apr 19, 2024 • edited Loading

Workflow status

raman-m commented Jun 25, 2024

raman-m commented Jun 25, 2024

nmbro left a comment • edited Loading

Choose a reason for hiding this comment

nils-a commented Jun 27, 2024

raman-m commented Jul 2, 2024

nils-a commented Jul 8, 2024

raman-m commented Jul 8, 2024

raman-m commented Jul 8, 2024 • edited Loading

P.S. FYI

nils-a commented Jul 8, 2024

nils-a left a comment

Choose a reason for hiding this comment

raman-m commented Jul 8, 2024

nils-a commented Jul 8, 2024

gep13 commented Jul 8, 2024

raman-m commented Jul 9, 2024

Bump the `Cake.Core` package to 4.0.0 #124

Bump the `Cake.Core` package to 4.0.0 #124

raman-m commented Apr 10, 2024 •

edited

Loading

raman-m commented Apr 19, 2024 •

edited

Loading

nmbro left a comment •

edited

Loading

raman-m commented Jul 8, 2024 •

edited

Loading