Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI workflow to remove the if that disables running on PRs #64

Open
nils-a opened this issue Aug 14, 2024 · 0 comments · May be fixed by #65
Open

Update CI workflow to remove the if that disables running on PRs #64

nils-a opened this issue Aug 14, 2024 · 0 comments · May be fixed by #65
Labels

Comments

@nils-a
Copy link
Contributor

nils-a commented Aug 14, 2024

In cake-contrib/Cake.Recipe#809 we established that the if in

# ...
build:
    runs-on: ${{ matrix.os }}
    if: github.event_name == 'push' || github.event.pull_request.head.repo.full_name != github.repository
# ...

does more harm than good, and should be replaced by limiting the branches which are build on push:

push:
  branches:
    - main
    - develop
    - "feature/**"
    - "release/**"
    - "hotfix/**"
    - "support/**"
  tags:
    - "*"
@nils-a nils-a added the Build label Aug 14, 2024
nils-a added a commit to nils-a/Cake.Discord that referenced this issue Aug 14, 2024
@nils-a nils-a linked a pull request Aug 14, 2024 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant